One thing I wanted to add is that the seed and password are hidden by default and the user needs to click to unveil them. Similar to how we hide the balance by default. Thoughts on that?

We should make it considerably difficult to show the seed and show various warnings, since it is a fatal action, potentially. Phoenix does this well, for example, we could do it in a similar way.

Edit: Just to be clear, I think it's fine for now as is, the above could be a future improvement.

One thing I wanted to add is that the seed and password are hidden by default and the user needs to click to unveil them. Similar to how we hide the balance by default. Thoughts on that?

Just to be clear, I think it's fine for now as is, the above could be a future improvement.

I agree with that.

Tested on Firefox/Brave ✔️ mobile/desktop ✔️ darkmode/lightmode ✔️ .
Looks superb yet again. Pixel-perfect.

We should make it considerably difficult to show the seed and show various warnings, since it is a fatal action, potentially. Phoenix does this well, for example, we could do it in a similar way.

Totally agree. The one difference from us to Phoenix is that we only show the seed once immediately after wallet creation. Still, if someone sees that seed they can still steal you funds later on after you funded your wallet. I tracked #65 to hide the seed and password and make the user actively reveal it. I'll try to get this in soon—I think we should already have that for the first release.

Thanks for the reviews guys! I'll merge this later today unless there's still some feedback to be addressed?

Totally agree. The one difference from us to Phoenix is that we only show the seed once immediately after wallet creation. Still, if someone sees that seed they can still steal you funds later on after you funded your wallet.

That's right. What's usually done in that case is that the user is quizzed, to make sure that the seed was written down. We should definitely make sure to do this and get it right, because loss of funds can occur if the user fails to write it down.

It say it's not super-duper critical since the first release will be an early beta release anyway, but still.

I think we should already have that for the first release.

I agree!

Thanks for the reviews guys! I'll merge this later today

Go from my side ✅